Skip to content

chore: fix correct filename for provenance file (#1492)#1497

Merged
jakobmoellerdev merged 1 commit into
open-component-model:releases/v0.23from
jakobmoellerdev:backport-0.23-prov-file-name
Jun 3, 2025
Merged

chore: fix correct filename for provenance file (#1492)#1497
jakobmoellerdev merged 1 commit into
open-component-model:releases/v0.23from
jakobmoellerdev:backport-0.23-prov-file-name

Conversation

@jakobmoellerdev
Copy link
Copy Markdown
Member

According to the helm
spec

assuming the presence of a file suffixed with .prov sitting next to a
chart .tgz in a repository.

This is why, we initially downloaded the provenance file into a file with only the .prov extension. However, according to the helm documentation

For example, if the base URL for a package is
https://example.com/charts/mychart-1.2.3.tgz, the provenance file, if it exists, MUST be accessible at
https://example.com/charts/mychart-1.2.3.tgz.prov.

Accordingly, we changed the filename for the provenance content to include the extensions of the original helm-chart

(cherry picked from commit ab3c2d9)

…#1492)

According to the helm
[spec](https://github.com/helm/community/blob/05eab5bba990d4f5556f90bfc001662d1a76f9a5/hips/hip-0006.md#2-support-for-provenance-files)

> assuming the presence of a file suffixed with .prov sitting next to a
chart .tgz in a repository.

This is why, we initially downloaded the provenance file into a file
with only the `.prov` extension. However, according to the [helm
documentation](https://github.com/helm/helm-www/blob/cf3e4f875101fa3f72ff6194499b5365723f0ec1/content/en/docs/topics/provenance.md)

> For example, if the base URL for a package is
https://example.com/charts/mychart-1.2.3.tgz, the provenance file, if it
exists, MUST be accessible at
https://example.com/charts/mychart-1.2.3.tgz.prov.

Accordingly, we changed the filename for the provenance content to
include the extensions of the original helm-chart

(cherry picked from commit ab3c2d9)
@jakobmoellerdev jakobmoellerdev requested a review from a team as a code owner June 3, 2025 10:38
@github-actions github-actions Bot added kind/chore chore, maintenance, etc. size/s Small labels Jun 3, 2025
@jakobmoellerdev jakobmoellerdev merged commit fe30b48 into open-component-model:releases/v0.23 Jun 3, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/chore chore, maintenance, etc. size/s Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants